Timeline
11/20/08: Today
- 08:49 Changeset [2824] by
-
Change to use $post->editlink in themes and remove trailing tab/space.
11/19/08: Yesterday
- 20:10 Ticket #273 (Use config directory as default directory to create an SQLite database) closed by
- fixed: Fixed in r2823
- 20:09 Changeset [2823] by
-
Create an SQLite db in either /user or /user/sites/url if only a file name is given in the config file, depending on whether it's a multisite installation or not. Change should be transparent to existing installations. If the config file contains a path instead of a bare file name, the path will be honored. Fixes ticket #273.
11/18/08:
- 22:26 Changeset [2822] by
-
Removing the session notice regarding setting a cookie when someone comments.
- 19:34 Ticket #759 (Installer: Javascript overhaul, experimental (but works)) created by
- Fixes: - Proper highlighting of borders - Shows the ? icon in Site Configuration (the <a> need to be outside h2) - Removes the extraneous ? icon in the Plugin Activation h2 - Removes the Array() stuff, "this" works with multiple selectors and each(). Other changes: - Per-schema functions in an object - Makes the Table Prefix always OK, it's an inconsistency to hide it since it's optional. Note: Some of the code repeats, I tried making a generic function but failed or made the code cumbersome... Purpose is to somewhat prepare for more "per-schema" action the handlers branch is working on, but also makes more sense to separate per-schema functions than a big one with unused code? (this is the experimental bit)
- 00:48 Changeset [2821] by
-
Changing an SQL call. Thanks arthus for the patch.
11/17/08:
- 21:59 Ticket #758 (Fatal error pops up at odd moment (plugin config)) closed by
- wontfix: Honeypot requires 0.6-dev
- 21:56 Ticket #758 (Fatal error pops up at odd moment (plugin config)) created by
- Setting up Habari (as a trial for now, running 0.5.2). Earlier, I selected and activated some of the core plugins. Now, I added a few I had downloaded earlier. I realize by now that not everything may be compatible with 0.5.2 anymore (but modules tend to give little information about that). My approach for these new plugins: 1) go through the list and activate the new ones one by one - the list is ordered alphabetically 2) go through the list of activated plugins to configure them (if applicable, but they all have a "configure" link These are the new plugins (in alpha order): * OpenSearch * Spam Honeypot * Spamview * Twitter * Twitter Silo Of these, Twitter is the first one that turns out to actually have a configure dialog; when I press Save, to my surprise I get an error message for an earlier plugin: "Fatal error: Call to a member function slice() on a non-object in <mydocroot>/user/plugins/spamhoneypot/spamhoneypot.plugin.php on line 33" What is surprising is not so much the error message in itself (the plugin may be incompatible with 0.5.2) but the fact that it appears when saving the configure dialog of a different plugin. Checking the database, I see that the configuration parameters for the Twitter plugin are saved correctly. I continue with Twitter Silo (also a real configuration form), and the same thing happens again.
- 19:02 Ticket #757 (Mising em value in Charcoal) created by
- http://trac.habariproject.org/habari/browser/trunk/htdocs/system/themes/charcoal/style.css#L540 It should be: […]
- 14:11 Ticket #756 (Filter bar for log viewer disappears) closed by
- fixed: Fixed it r2208 and previously reported in #549
- 13:53 Ticket #756 (Filter bar for log viewer disappears) created by
- Exploring my very first (trial install)... When I go to the Logs screen I can the first log entries and choose various criteria to filter on (I tried with the type - notice, info, etc. column). That works nicely, until I choose a filter that doesn't match anything: it then (correctly) tells me there are no entries - but the filter bar also disappears, so you can no longer choose other filter criteria. IMO the filter bar should remain visible and usable at all times, whether or not any log entries are found.
- 04:39 Changeset [2820] by
-
We neglected to add the admin group to a new installation when we added the admin group on updates to r2264.
- 02:30 Changeset [2819] by
-
Removing the index.php installer calls, fix the default form values, also fix the locale change. Will probably cache the FormUI since we call locale-form twice... and probably more during install. Oh and fixed the class change of installstep rather than options.
11/16/08:
- 05:02 Ticket #755 (Format::humane_messages) created by
- Because you humanMsg.displayMsg('{$error}'); and wrap the $error in single quotes you need to escape newlines else it will cause JavaScript issues. You can also replace single quotes with double quotes and it will fix this.
- 01:47 Changeset [2818] by
-
A lot of stuff: removed InstallSchema, renamed install.php, moved the InstallHandler calls to Controller using a constant, new class Installer. This is all experimental so it will change to be much nicer especially the DB stuff.
11/15/08:
- 17:22 Ticket #754 (Plugins::is_loaded() returns TRUE for inactive plugins) created by
- Plugins::is_loaded() is returning TRUE for inactive, but available (ie appears in the plugins list in the Inactive section) when it should only be returning TRUE for active plugins. I've tested this with r2817.
- 05:28 Ticket #753 (AdminHandler Line 24) created by
- On this line of the AdminHandler class file: echo '{callback: function(){location.href="'.$_SERVERHTTP_REFERER?.'"} }'; You need to confirm that $_SERVERHTTP_REFERER? isset, otherwise I recommend forward users to the blog index.
- 04:13 Changeset [2817] by
-
Moving the DB credential checks to their schema js files.
- 00:53 Ticket #752 (Implement search for plugins page) closed by
- fixed: in r2816
- 00:51 Changeset [2816] by
-
Adding search to the plugins page. Thanks arthus! Closes 752
11/14/08:
- 22:32 Ticket #752 (Implement search for plugins page) created by
- Allow plugins page to be easily searched, in a similar way to the options page.
- 21:50 Changeset [2815] by
-
Moving the schema install files to a subdir, worked on the JS. FormUI for schemas is now complete, need to work on the backend now\!
- 19:24 Changeset [2814] by
-
Add reasonable defaults to a new install for date/time.
- 17:52 Changeset [2813] by
-
FormUIze Installer, allow schemas to hook it and add their db-specific fields. InstallSchema extends Pluggable so actions/filters/etc are registered in schemas... many more changes
- 17:52 Changeset [2812] by
-
Adding _after hooks after template_header and admin_header are executed.
This effectively reverts r2811 and re-implements it in a better way.
- 16:38 Changeset [2811] by
-
Moving the admin_header plugin hook below stylesheet and javascript output so that plugins can properly execute things that require or override a default include.
- 16:02 Changeset [2810] by
-
Remove the enforced date formats in system themes. We have an option to control date and time format now, let's use it.
- 14:27 Ticket #751 (SQLite runs all inserts that are located in schema.sql on every upgrade) closed by
- fixed: Fixed in r2809. Thanks for the pointer, chrismeller.
- 14:25 Changeset [2809] by
-
Only run insert/update queries in SQLite if told to do so.
11/13/08:
- 23:27 Ticket #603 (Tags with 0 items should auto-delete) closed by
- fixed: Fixed in r2876.
- 22:24 Changeset [2808] by
-
Removing the left border radius for submenus, since it looks dumb. As always, !important saves the day with our crazy admin CSS structure...
- 19:59 Ticket #45 (DatabaseConnection includes database-specific code, which it should not) closed by
- fixed: Closing it, even.
- 19:57 Changeset [2807] by
-
Get RDBMS-specific code out of the file. This functions isn't currently used in Habari. Of the backends we are currently supporting, MySQL supports the function as written, Postgress appears to use EXEC instead of call and so needs a transformation written in it's sql_t() function, and SQLite doesn't support stored procedures at all, though it does support a form of dynamically loaded functions.
Fixes ticket #45.
- 18:51 Changeset [2806] by
-
Moving the admin stacks initialization into AdminHandler's constructor, where it should have been to begin with.
If you need stacks from a plugin, call the AdminHandler::setup_stacks() method, then check the stack.
- 17:43 Ticket #751 (SQLite runs all inserts that are located in schema.sql on every upgrade) created by
- Whenever the database is upgraded, SQLite runs all insert statements that are located in the basic schema.sql file. Right now, that means that the permissions and the post object type are added, resulting in multiple instances of these in the database.
- 12:36 Ticket #431 (Monolith: Date link on Comments page is blank) closed by
- fixed: Fixed in r2186.
- 07:06 Ticket #750 (Keyboard shortcuts no longer working) closed by
- fixed: fixed in r2805
- 07:05 Changeset [2805] by
-
Fix the carrots in the menu. Add some potatoes and green beans. This soup is getting tasty.
- 00:20 Ticket #750 (Keyboard shortcuts no longer working) created by
- Somewhere during the last few changesets, the admin menu's keyboard shortcut stopped functioning.
11/12/08:
- 19:17 Changeset [2804] by
-
Actually save changes in group membership to the database.
- 19:03 Changeset [2803] by
-
Deleting an unused style block from the admin's css... If this breaks something, it's not my fault - arthus made me do it!
- 09:48 Changeset [2802] by
-
Fix collateral changes :)
- 09:41 Changeset [2801] by
-
Leave the decision whether to continue processing after adding a redirect header up to the surrounding code. Keeps #749 fixed. Also removed now superfluous exit()s.
- 00:58 Changeset [2800] by
-
cast port to string for comparison (can't compare an object to an int, and PHP doesn't toString() it)
- 00:55 Changeset [2799] by
-
make installer work with new String/SuperGlobals classes
- 00:52 Changeset [2798] by
-
add server to superglobal breakout, also: remove type hinting and handle as array OR SuperGlobal in constructor
- 00:50 Changeset [2797] by
-
whitespace before I attack this file
11/11/08:
- 23:55 Ticket #593 (Activation of Habari Media Silo: display error message needed?) closed by
- fixed: I can confirm that #749 fixes this; a log message is displayed.
- 23:44 Ticket #749 (Utils::redirect) closed by
- fixed: I believe it's actually stated on the php.net documentation for Header() that if you redirect, it's up to the client to actually follow that directive and your script should not assume that it is going to continue processing (or that it's not). Once you call redirect, you should assume that's it - the user is going elsewhere. Any code that expects otherwise is contrary to the standard and should handle it differently itself. This is fixed in r2796.
- 23:38 Changeset [2796] by
-
Kill the current page once we redirect it. Fixes #749 and #593 supposedly.
- 23:08 Ticket #749 (Utils::redirect) created by
- This function needs to have exit(); added to the bottom of it. Without it there are a few security risks but the main problem is that when attempting to activate "Habari Media Silo 1.0" nothing happened for me. Turned out that while using Utils::redirect php continued to execute and would clear my Session message before reloading. This prevented me from seeing an error message about my web server not having permission to create a directory called 'files'.
- 22:17 Ticket #748 (Installation Layout Issue) created by
- There is a layout flaw on the installation process. If you're directory isn't writable and you get the Config.php step the Locale Language selector is shown but isn't even put within the form. This is using the SVN revision 2793.
- 22:14 Changeset [2795] by
-
another PHP 5 change
- 22:10 Changeset [2794] by
-
cleanup (PHP 5-itize), and make process_gpc() single-run.
- 18:14 Ticket #520 (Admin menu should have Create and Manage items with content types as sub ...) closed by
- fixed: Fixed in r2793, for real this time.
- 18:12 Changeset [2793] by
-
Properly makes the corners of submenus in the admin rounded. Thanks, arthus! Fixes #520.
- 18:06 Changeset [2792] by
-
Updates for ArrayObject behavior. Still can't load k2 due to paginator problems.
- 17:25 Changeset [2791] by
-
Reverting r2788 that fucked up the admin.
- 17:05 Ticket #520 (Admin menu should have Create and Manage items with content types as sub ...) reopened by
- This totally screwed up the main menu in Firefox. Hotkeys shoot to the top and styles are entirely screwed up. Please revert to my last version. I will add padding and shadow if it is important.
- 14:11 Changeset [2790] by
-
Adding String and SuperGlobal class.
- 14:09 Changeset [2789] by
-
Create a branch for default input filtering on superglobals.
- 12:52 Ticket #715 (Admin: Menu flashes or closes when timer expires?) reopened by
- What browser is this happening with?
- 12:47 Ticket #709 (Options::set() should support arrays) reopened by
- How about having Options::set always serialize the value? Then you get out whatever you put in.
- 12:08 Ticket #674 (Atom: Feed does not send a <published> date.) closed by
- invalid: Nevermind me, am insane.
- 12:07 Ticket #709 (Options::set() should support arrays) closed by
- invalid: Nevermind me, probably nitpicking.
- 12:07 Ticket #715 (Admin: Menu flashes or closes when timer expires?) closed by
- invalid
- 12:07 Ticket #715 (Admin: Menu flashes or closes when timer expires?) reopened by
- 12:07 Ticket #715 (Admin: Menu flashes or closes when timer expires?) closed by
- fixed: Nevermind me, probably nitpicking.
- 12:05 Ticket #733 (FormContainer: Provide a clean sleight for each control template) closed by
- invalid: Nevermind me, you'll prolly have better patches.
- 12:05 Ticket #738 (Theme.php has leftover ringmaster comment) closed by
- invalid: Nevermind me, you'll prolly have better patches.
- 12:05 Ticket #743 (Theme: Pagination should use implode()) closed by
- invalid: Nevermind me, you'll prolly have better patches.
- 12:04 Ticket #747 (Installer: Convert XHTML documents into HTML documents.) closed by
- invalid: Nevermind me, you'll prolly have better patches.
- 12:04 Ticket #746 (Installer: Fix $tab errors.) closed by
- invalid: Nevermind me, you'll prolly have better patches.
- 11:43 Ticket #747 (Installer: Convert XHTML documents into HTML documents.) created by
- config.php, sqlite.php and requirements.php are XHTML documents. On top of that, they do not use the same template db_setup.php or htaccess.php use. Patch installer-2.patch uses htaccess.php as a base for config.php and sqlite.php requirements.php Since this file clearly needs more work than some copy/pasting, the patch does not alter it. Do not close the ticket before this file has been accounted for. Thank you!
- 11:38 Ticket #746 (Installer: Fix $tab errors.) created by
- With E_STRICT, an error is triggered since $tab is not initialized prior to $tab++. This renders all files without it useless as the error halts the parsing. Patch installer-0.patch fixes RandyWalker's mishap in r2788. Patch installer-1.patch adds required $tab initializations. Please make two separate commits.
- 11:10 Ticket #520 (Admin menu should have Create and Manage items with content types as sub ...) closed by
- fixed: Fixed in r2788.
- 10:45 Changeset [2788] by
-
Adds drop shadows and/or rounded corners to submenus in browsers that support these features.
- 09:04 Ticket #520 (Admin menu should have Create and Manage items with content types as sub ...) reopened by
- The submenus don't have the same padding or drop shadows as the main menu. It looks awkward. See "dashboard.png" attachment.
- 08:00 Ticket #520 (Admin menu should have Create and Manage items with content types as sub ...) closed by
- fixed: Last patch was committed in r2787. This looks resolved to me. Please re-open if there's something I am missing.
- 07:58 Changeset [2787] by
-
Adding round corners to sub-menus. Thanks arthus. With this, #520 closed can be.
- 04:42 Ticket #745 (Tag Number not updating) closed by
- fixed: This was fixed in r2786. On upgrade your database should be fixed up all spiffy and new - tag2post links are cleaned up and tags with no more posts are deleted. I enjoyed this maddening journey down insanity lane, thanks!
- 04:40 Changeset [2786] by
-
Added code to de-link Tags from Posts when a post is deleted (also deleting the tag if it no longer has any posts and filter says it's alright). Fixes #745. Thanks to wilcosworld for the interesting bug report!
Also refactors the tags page in the admin to move the tag retrieval logic out of the theme's view code. Damn you, MattRead!
11/10/08:
- 15:39 Ticket #745 (Tag Number not updating) created by
- On the tag admin page, the number of pages/entries attached to each tag does not correctly update when you delete the pages/entries. e.g. When you have two posts labelled as 'test' the tag admin page will show a '2' next to the 'test' tag. However, if you delete one of the posts, the tag will still have a '2' next to it.
- 15:17 Changeset [2785] by
-
Fixed comments linking to the current page if no author URL was specified. This should probably be checked for all other themes too, but I'm lazy like that.
- 15:07 Changeset [2784] by
-
Adding the "checkbox" class to checkboxes on the users and logs pages so that the range selection code works.
- 12:34 Ticket #744 (Charcoal's $theme->post_comments_link() doesn't support internationalized ...) created by
- It's impossible to translate %s Comments correctly to languages that have more than one plural form.
- 05:38 Changeset [2783] by
-
adding some very basic default style to formUI elements so they aren't so squished :P
- 04:49 Changeset [2782] by
-
Allow plugins to add script to the admin_header_javascript stack
11/09/08:
- 08:49 Ticket #743 (Theme: Pagination should use implode()) created by
- Using implode() prevents extra spacings.
- 07:14 Ticket #740 (Undefined variable: [digest|timestamp|nonce] in ...) closed by
- fixed: Fixed in r2781.
- 07:13 Changeset [2781] by
-
Added wsse variables to the admin user page. Fixes ticket #740.
- 03:05 Ticket #742 (WP Import) created by
- Though this might be a rare event, and I did my own fix for this, when using imports, in particular I was using the WP Import, you have to escape quotes in values when printing to JavaScript. $( document ).ready( function(){ $( '#import_progress' ).load( "{$ajax_url}", { db_host: "{$db_host}", db_name: "{$db_name}", db_user: "{$db_user}", db_pass: "{$db_pass}", db_prefix: "{$db_prefix}", category_import: "{$category_import}", utw_import: "{$utw_import}", postindex: 0 } ); } ); If you have a quote (") then you need to escape it (\").
11/08/08:
- 20:54 Changeset [2780] by
-
Merging changes to atomhandler in trunk to the dom branch.
- 16:55 Changeset [2779] by
-
Removing 0.5.3 branch, seems we use makaanga for releases... PMC will do 0.5.3
- 16:34 Changeset [2778] by
-
Making a branch for 0.5.3 release.
- 16:21 Ticket #741 (Mzingi: Use $theme object rather than Controller::get_var()) closed by
- fixed: in r2777.
- 16:20 Changeset [2777] by
-
using the tag var instead of the controller var. Thanks freakerz.
- 16:05 Ticket #741 (Mzingi: Use $theme object rather than Controller::get_var()) created by
- See patch for more details.
- 11:34 Changeset [2776] by
-
Coding standard changes.
- 10:27 Ticket #740 (Undefined variable: [digest|timestamp|nonce] in ...) created by
- Saving user information (admin/user) results in the following 3 log messages: […] Noticed with r2775, but probably exists for earlier revs too. I've only had a quick look, but it looks like these aren't being passed with the handler_vars that get "extracted" on line 676. I'll check properly later when I've got a bit more time.
- 09:41 Changeset [2775] by
-
Finished amending the bootstrap file to work
- 09:11 Changeset [2774] by
-
Added a conditional so we can set the test db config beforehand if unit testing
- 09:05 Changeset [2773] by
-
Added a custom config.php for the test run
- 06:30 Changeset [2772] by
-
Merging trunk into branches/phpunit
- 04:16 Ticket #723 (Posts: Add an option to retrieve posts with deactivated content types) reopened by
- Applying the patch causes the admin page to crash the comments admin page.
- 04:14 Changeset [2771] by
-
Reverting r2770. Something's wrong with that query that's causing the comments page to crash (?).
- 03:13 Ticket #723 (Posts: Add an option to retrieve posts with deactivated content types) closed by
- fixed
- 03:11 Changeset [2770] by
-
Include posts with deactivated content types, excluded by default. Thanks freakerz for the patch. fixes #723.
- 02:46 Changeset [2769] by
-
There is no such option as default_datetime_format. use a combination of dateformat and timeformat instead.
- 02:40 Changeset [2768] by
-
Correct css selector for helptext and tweeking the width for the helptext in the options page.
- 02:06 Changeset [2767] by
-
Remove the black underlines of the delete button
- 01:59 Changeset [2766] by
-
Add the JS stack after defining the required variables. Thanks freakerz for the fix!
11/07/08:
- 22:24 Changeset [2765] by
-
Making setup_stacks a static method.
- 22:02 Changeset [2764] by
-
Setup the admin javascript stack here, so that we can maintain the correct order of inclusion. It would be nice if we could pass and order argument to Stack::add().
- 21:14 Changeset [2763] by
-
Forgot to add the call to setup_stacks to act_admin
- 21:02 Changeset [2762] by
-
Lets move that Stack creation call to its own function so that the stack can be accessed outside of the admin, like say in my gears plugin.
- 18:15 Changeset [2761] by
-
Moving all the default admin JS files to use the Stack metaphor.
We have an admin_javascript stack, we should be using it.
- 02:32 Ticket #675 (XMLRPC: Utils does one too many strotime() on XMLRPCDate.) closed by
- fixed: Fixed in r2760. Thanks for the patch, freakerz.
- 02:31 Changeset [2760] by
-
Removed an excess strtotime(). Thanks for the patch, freakerz! Fixes ticket #675.
- 01:01 Ticket #737 (Options::get_group() substrings only the last char, not the last two) closed by
- fixed: Fixed in r2759. Thanks for the patch, freakerz.
- 00:59 Changeset [2759] by
-
Look 2 characters back from the end of the string for '', not 1. Thanks for the patch, freakerz. Fixes ticket #737.
11/06/08:
- 22:36 Ticket #739 (Admin Theme posts.php) created by
- Minor issue but easy to fix as well. In the admin theme, posts.php, the bottom controls are not cleared. (Controls being the hidden inputs, select/deselect all button, and the delete selected button) After the <input type="button" value="<?php _e('Delete Selected'); ?>" class="delete button"> You need to put <div class="clear"></div>
- 03:52 Ticket #738 (Theme.php has leftover ringmaster comment) created by
- Also adds comments to use template_engine's assign() when the var_stack has been emptied, otherwise the variables won't be available.
- 03:14 Ticket #698 (Weird commenting cookie issue..) closed by
- worksforme: Closing, seems I'm the only one experiencing... now I use several browsers, Safari is gone! :)
- 02:43 Ticket #737 (Options::get_group() substrings only the last char, not the last two) created by
- Options::get_group('prefix__') would use the prefix prefix_____. Patch changes the -1 to -2.
11/05/08:
- 18:26 Ticket #736 (Cannot deactivate plugin 'Pingback 1.0') created by
- When upgrading to 0.5.2 I tried to deactivate the 'Pingback 1.0' plug in. I received the following error: Warning: PDOStatement::execute() [pdostatement.execute]: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'ruhwedell_dk.log' doesn't exist in system/classes/databaseconnection.php line 261 The table ruhwedell_dk.log doesn't exist. The table ruhwedell_dk.habarilog does on the other hand. When I installed Habari I chose to use a prefix habari. Everything else works fine. So prefixing must be working? I have not changed any code in my Habari installation. I have submitted this with priority 'major' but it might not be since I can still upgrade my Habari installation from 0.5.1 to 0.5.2.
11/04/08:
- 19:44 Ticket #735 (Create Entry - Content Address Enhancement) created by
- It would be nice if there was some form of "help" or something to understand what Content Address means.
- 19:42 Ticket #734 (Create Entry Publication Time User Interface) created by
- I am having difficulties understanding the Publication Time user interface. Some countries format their dates and whatnot differently, and so if I saw 2009-05-06 is that June 5th or May 6th? I would prefer a multiple drop down system to make it easy to understand with months being written out, instead of numbered.
- 16:57 Changeset [2758] by
-
This smells like duplicated code.
- 16:52 Changeset [2757] by
-
Fix typo, add both cases for the (un)approve actions.
- 15:11 Ticket #673 (Habari silo doesn't display Upload options (Firefox 3.0.3, Chrome)) reopened by
- 07:32 Ticket #733 (FormContainer: Provide a clean sleight for each control template) created by
- This is a note in FormContainer::get() […] It needs to be addressed, because if we set, for example, a first control's "required" property to 'true', if the second control doesn't have that property, it will inherited the first's... It isn't causing problem right now because all controls overwrite each other's properties or inherited properties aren't used by the template.
- 02:53 Changeset [2756] by
-
make import a little more pretty
- 02:13 Changeset [2755] by
-
add enctype attr to formui form
- 01:06 Changeset [2754] by
-
Handlers branch: Moving admin and installer to themes, moving admin ajax to AjaxAdminHandler, added a theme.php, more to come.
11/03/08:
- 21:11 Changeset [2753] by
-
add WSSE check and move extract so vars cannot be overriden
- 20:48 Changeset [2752] by
-
sanitize username for html output
- 20:10 Ticket #673 (Habari silo doesn't display Upload options (Firefox 3.0.3, Chrome)) closed by
- fixed: Fixed in r2751
- 20:10 Changeset [2751] by
-
Fix non-existant permission check. fixes #673.
- 13:16 Ticket #673 (Habari silo doesn't display Upload options (Firefox 3.0.3, Chrome)) reopened by
- Nope. This fix does not work for me. I still do not see the 'Upload' or 'Create Directory' links. Something is going wrong in the permissions checking, because my user/files directory permissions are set to 777. Ownership is set to user:user. Also tried user: nobody. Nothing works. I am running the latest trunk version. These hacks are unprofessional in any case. The software needs to do everything to make it work, not expect people to create sub directories, .htaccess and set permissions manually.
- 02:59 Changeset [2750] by
-
$updates should be an array, not a string. Fixes a problem with passing an invalid variable to the dashboard.
11/02/08:
- 16:50 Ticket #732 (Tag and DB have different names on stuff) created by
- When creating a new tag using new Tag() this is used: return array( 'id' => 0, 'tag_slug' => , 'tag_text' => ); tag_slug and tag_text. But when fetching tags using Tags::get() it returns tags with return array( 'id' => 0, 'slug' => , 'text' => ); Both should use the same layout
- 03:32 Ticket #731 (GUI for readme files) created by
- It was suggested IRC that we provide GUI access for readme files packaged with plugins. This should probably be accessible via the dropbutton on the plugins page. The data would be read out of the plugin's (optional) readme file, which should probably be html. This would be very useful for install instructions and such.
11/01/08:
- 15:03 Ticket #730 (RemoteRequest Allocates Excess Memory) created by
- RemoteRequest, whether it uses cURL or sockets, allocates excess memory when making the request. With cURL, around twice as much memory as is needed is allocated. I've tracked the reason down to using CURLOPT_RETURNTRANSFER and reading the results directly into a variable. The attached patch fixes this by creating a temporary file, sending the results to it, then reading the file to get the results. It works for me, but I would appreciate it if it could be reviewed and tested on other systems before it is commited.
- 02:31 Changeset [2749] by
-
Moving all the initial default date and timezone code out of index.php and into the HabariDateTime class where it belongs.
- 00:34 Changeset [2748] by
-
Mergine changes from tunk (except for Atomhandler) into the DOM branch.
10/31/08:
- 00:02 Changeset [2747] by
-
ErrorHandling branch: Remove Error::trigger_error() and E_DEBUG... lets just use DEBUG, removing comments and adding some
10/30/08:
- 18:03 Changeset [2746] by
-
More goodies, don't mind the throws and such, that'll get fixed later...
- 17:53 Ticket #729 (Installer: Default `en-us` locale saved as `en_us`) closed by
- fixed: Fixed in r2745. Thanks, freakerz, for finding the problem and the patch.
- 17:51 Changeset [2745] by
-
Fix a mis-typed '-'
- 17:49 Ticket #729 (Installer: Default `en-us` locale saved as `en_us`) created by
- Patch corrects the issue.
- 14:37 Ticket #728 (PHP5 Version Compare) closed by
- fixed: Some good points. I think I'm the one who originally put error reporting above the compare anyway, so I've fixed it in r2744. Thanks!
- 14:36 Changeset [2744] by
-
Moving the PHP version check up to be the first action to avoid some potential problems with older versions as pointed out by xvolter in #728.
- 14:22 Ticket #728 (PHP5 Version Compare) created by
- Within index.php there is a check for PHP version. Though I understand this is needed, it should be moved up. (remove comments in example) Here you do: error_reporting( E_ALL | E_NOTICE | E_STRICT ); date_default_timezone_set( 'UTC' ); if ( ! version_compare( PHP_VERSION, '5.2.0', '>=' ) ) { die ( 'Habari needs PHP 5.2.x or higher to run. You are currently running PHP ' . PHP_VERSION . '.' ); } When in PHP4 the term E_STRICT doesn't exist. I code all my scripts in E_ALL in PHP4 so this would promote a problem. I think that the version_compare should be moved up above the error_reporting.
- 10:40 Ticket #727 (Allow plugins to user other javascript libraries in admin) created by
- If they so desire, plugins should be allowed to use other javascript libraries in the admin. Reported on -dev: http://groups.google.com/group/habari-dev/browse_thread/thread/f47147edadc6104a
- 05:34 Changeset [2743] by
-
ErrorHandling Branch: Bunch of cool stuff, proposed system would use PHP functions rather than Error::raise()... see code for more! (and expect more)
- 04:08 Changeset [2742] by
-
Get rid of some unnecessary code duplication.
10/29/08:
- 19:03 Changeset [2741] by
-
Merged trunk in error-handling branch.
- 15:11 Ticket #726 (Replicate list navigation below lists (comments, content, etc.)) created by
- Any page with the timeline/list schema should have navigation above AND below the list. When scrolling through a list of comments, I currently have to go back to the top to click Older. I'd like to have the older/newer/timeline replicated at the bottom and clicking Older/Newer should change the page and take me to the top.
- 15:03 Ticket #725 (Gracefully handle a missing database) created by
- When the database server is down, Habari throws raw errors at the visitor: […] There should be a nice, user-friendly page to inform the visitor that the site is currently unavailable.
- 15:01 Ticket #724 (Database errors logged with wrong module/severity?) created by
- My Habari (@2740) logs database errors like: […] as module=Error, type=default, severity=any, when it should probably be module=habari, type=database, severity=error.
- 05:41 Ticket #723 (Posts: Add an option to retrieve posts with deactivated content types) created by
- What ringmaster wants, ringmaster gets. By default, Posts::get() would not retrieve posts with deactivated content types.
- 03:09 Ticket #702 (Installer calling PDO even if not present) closed by
- fixed: Fixed in r2740.
- 03:09 Changeset [2740] by
-
Fixes a PDO error in the installer if PDO is not loaded at the time. Fixes #702. Thanks, freakerz!
- 03:05 Ticket #706 (Don't display "Add item" module if no modules available) closed by
- fixed: Fixed in r2739.
- 03:05 Changeset [2739] by
-
Hides the 'Add item' module if there are no modules available. Fixes #706. Thanks, freakerz!
- 02:53 Ticket #705 (Display session expiry message when relevant) closed by
- fixed: Fixed in r2738.
- 02:53 Changeset [2738] by
-
Fixes the session error message claiming your session has expired every time you visit the login page. Fixes #705. Thanks, freakerz!
- 02:41 Ticket #717 (Installer: htaccess.php $tab issue) closed by
- fixed: Closing, committed in r2733. Thanks BigJibby!
- 02:29 Ticket #719 (ACL: Return $false in UserGroup.php) closed by
- fixed: Fixed in r2737. Thanks!
- 02:28 Changeset [2737] by
-
Fixing an extra $. Shame on you, skippy, you're no longer the project Baron! Fixes #719. Thanks, freakerz!
- 02:26 Ticket #718 (EventLog: Orders logs by ascending ID order.) closed by
- fixed: Fixed in r2736. Thanks!
- 02:25 Changeset [2736] by
-
Adding an additional ORDER BY clause for displaying log entries. Fixes #718. Thanks, freakerz!
- 02:24 Ticket #722 (ACL: token_id() does not return an integer.) closed by
- fixed: Fixed in r2735. Thanks!
- 02:23 Changeset [2735] by
-
Committing the ACL fix from ticket #722. Thanks, freakerz!
- 02:17 Ticket #722 (ACL: token_id() does not return an integer.) created by
- Other methods expect an integer, so have token_id() type cast the value it returns. Patch does so.
- 01:15 Ticket #721 (User/UserGroup: Create() should check if user/group already exists.) created by
- The following exception is thrown when an existing UserGroup is inserted. Same for an existing User (looking at the code). […] We should prevent this issue by checking if User/UserGroup already exists. It is currently checked in the AdminHandler::post_users() but for plugins creating users or groups, it won't get checked. Question is, how should we respond (return) to existing users. If we return "true", what if the existing group has a different description than expected. If we return "false", then there's no way for caller to know what went wrong. Could we throw an exception? Right now this isn't useful, but with teh errorhandling branch, I could try and implement it…
10/28/08:
- 22:56 Ticket #720 (ACL: Permission deny inserted as 'denied' in schema.sql) created by
- Hopefully this patch is complete, but will need review from people who have done DB upgrades before.
- 22:55 Ticket #719 (ACL: Return $false in UserGroup.php) created by
- Patch removes the extra $.
- 22:37 Ticket #718 (EventLog: Orders logs by ascending ID order.) created by
- If several log entries have the same timestamp, it currently orders them by ascending order of ID. Patch adds ORDER BY id DESC.
- 19:46 Changeset [2734] by
-
Silencing an undefined variable warning.
- 17:48 Changeset [2733] by
-
Applying patch from #717. Thanks andrewdasilva.
- 17:41 Ticket #717 (Installer: htaccess.php $tab issue) created by
- Arranged the indentation and made the code look more like db_setup.php's. Also removed the XHTML bits and pieces and added the tabindex stuff. Patch also removes a residual /> in db_setup.php!
- 06:04 Changeset [2732] by
-
Removing the ghastly colours from the admin
- 04:23 Changeset [2731] by
-
I also don't need to leave commented out lines in the file.
- 04:19 Changeset [2730] by
-
Added colors to liven up the drab admin.
- 04:18 Changeset [2729] by
-
Only run upgrade sql files once. there's no real need to run it again on the next db version upgrade. In this particular case, dates in SQLite were being tromped because dates that were being run through strftime() twice, once at the original upgrade, and again at the next db version update.
- 01:55 Changeset [2728] by
-
Fixed two issues: an undefined variable if the update fails and an unrelated potential error condition that manifested itself at the same time.
10/27/08:
- 20:12 Changeset [2727] by
-
Made 'Add Item' for dashboard modules a localized string so it can be translated.
- 20:03 Changeset [2726] by
-
updating .pot file
- 17:20 Changeset [2725] by
-
Sanitize data on output, in context.
- 10:53 Ticket #716 (Theme::page_selector() should optionally return a link if only 1 page of ...) created by
- At the moment the Theme::page_selector() function ALWAYS returns a link when called, even if there is only one page of results/output. This seems a bit odd: why show pagination when there's nothing to paginate? I think the page_selector() function should return nothing (or maybe just a ) by default and accept a new boolean setting, eg "displayOne", to allow people to override this and display the 1. Attached is an example patch for such a change.
- 03:27 Changeset [2724] by
-
Merging trunk to handlers branch.
- 03:22 Changeset [2723] by
-
Merging trunk to rewriterules branch.
- 03:10 Changeset [2722] by
-
Merging trunk to error-handling branch.
- 02:26 Changeset [2721] by
-
Moving a wild brace that had somehow escaped it's stall.
- 02:12 Changeset [2720] by
-
Merging current trunk into branches/phpunit
- 01:50 Changeset [2719] by
-
Change the way comment menus are generated. Thanks, arthus. Restored comment action names into the menu.
10/26/08:
- 23:54 Ticket #715 (Admin: Menu flashes or closes when timer expires?) created by
- I'll go out on a limb and say it's a timer expiry thing... But check the video: http://gallery.me.com/andrewdasilva#100030
- 19:17 Ticket #714 (Utils::slugify strips all characters (unicode bug?)) created by
- Utils::slugify removes all characters from the given string. No special locale/env settings I noticed, but \p{N} and \p{L} obviously don't work. OpenSuSE 10.2
- 15:30 Changeset [2718] by
-
Prevernts the redirect from loading the page and kill the session messages.
- 15:25 Changeset [2717] by
-
Pingback options go in the pingback plugin, not core.
- 15:14 Changeset [2716] by
-
Use a more MVC mentality for the comment moderation page. Use the internal array of statuses for the action menus rather than hardcoding statuses into the list. Allow filtering of the comment action menu for global menus and for individual comments. Allow filtering of available comment status (probably not going to work by itself since a large portion of code uses hardcoded values).
- 13:45 Changeset [2715] by
-
Somehow missed this file on add. Add status key/value items to the array via the dashboard_status filter to create a new dashboard module without writing dashboard module code.
- 01:18 Ticket #690 (Comment moderation page should be more pluggable) closed by
- fixed: in r2714, thanks RandyWalker
- 01:11 Changeset [2714] by
-
Adds hooks to allow external comment filters.
10/25/08:
- 23:05 Changeset [2713] by
-
Adding tabindex properties to select and checkbox options template and enabled tabing in options page.
- 22:26 Changeset [2712] by
-
fixes for new and manage submenus
- 19:03 Ticket #712 (Timezone Feedback) closed by
- fixed: I added an ugly-looking fix for this in r2711. It needs display love, but it works.
- 19:00 Changeset [2711] by
-
Added some basic helptext support to the admin options page so we can display the current timezone and date and time formats when a user saves them. Some CSS love is obviously needed...
- 18:48 Changeset [2710] by
-
By popular demand, assuming you want to log backtraces if the DEBUG constant is set.
- 18:47 Changeset [2709] by
-
Adding the logging backtraces option to the options page. Looks like I forgot a file when I made the original implementation commit.
- 18:24 Changeset [2708] by
-
Added some new convenience psuedo-properties to HDT objects that allow you to output a date or a time in the format specified in Options.
- 18:04 Changeset [2707] by
-
Added a db post-upgrade method to the InstallHandler that sets actual values for the DateTime-related options and incremented the db version so it gets run.
- 17:16 Ticket #689 (Safari problems with <label>/<input> on admin login (again)) closed by
- fixed: Closing this because it doesn't seem to be happening to me anymore (running head)
- 17:15 Ticket #711 (Iterating on objects with next(), current() etc. no longer supported in ...) closed by
- fixed: *sigh* PHP is going to keep doing that. Anyway, the iteration functions are only used in Charcoal theme as far as core is concerned. This is fixed in r2706. Thanks.
- 17:14 Changeset [2706] by
-
Casting $posts to an array in preperations for PHP 5.3. Iteration functions will no longer support objects.
- 16:46 Ticket #713 (Publishing Options Config) created by
- Within the Publishing Options, one should be able to set the Entries per: 'Page', 'Feed', and 'Result', (result being search or tag). Not sure if the Formui lets this be accomplished on one line rather than three.
- 16:23 Ticket #712 (Timezone Feedback) created by
- When I set a Timezone in Habari, I have no real way of knowing that Habari agrees with me the time and date. What I am suggesting is some feedback that prints the time next to the box. Example: I select 'Greenwich' and the printout reads "Saturday 25/10/08 17.23"
- 12:13 Ticket #711 (Iterating on objects with next(), current() etc. no longer supported in ...) created by
- The problem is really serious, while running under PHP 5.3 habari with 'charcoal' theme does not display posts and outputs many PHP errors of course like this one: Warning: reset() expects parameter 1 to be array, object given in system/themes/charcoal/home.php line 5 It may occur in some other cases too but I don't have currently time to investigate it. The simplest solution I figured out is to cast object of Posts class to an array. I don't attach a patch, it's just a line: system/themes/charcoal/home.php: before (line 4) <?php if ( sizeof( $posts ) ): ?> add <?php $posts = (array) $posts; ?>
- 04:04 Changeset [2705] by
-
Moving content types into submenus. Initial work done on #520. Thanks, arthus.
10/24/08:
- 14:39 Ticket #710 (TEST PART #swhack PRIVMSG #swhack :BAI2U) closed by
- invalid
- 14:35 Ticket #710 (TEST PART #swhack PRIVMSG #swhack :BAI2U) created by
- 06:52 Ticket #708 (Post object incomplete when passed to plugins) closed by
- fixed
- 05:05 Ticket #709 (Options::set() should support arrays) created by
- We should be able to pass an array of options to set. Patch to come,