Ticket #4 (closed defect: fixed)

Opened 11 months ago

Last modified 10 months ago

OpenID login fails when URL is not associated with a user

Reported by: michaeltwofish Owned by: somebody
Priority: major Component: openid
Keywords: OpenID, has_patch Cc:

Description

On an attempted login, the OpenID plugin tests if Users::get_by_info( 'openid_url', $openid ) is true. However, if no users exist with this info, an empty Users object is returned, which evaluates to true. The attached patch tests count($user) != 0 instead. This works, but there may be a more elegant solution.

(This is http://trac.habariproject.org/habari/ticket/178, which should have been opened here.)

Attachments

openid_login.patch (0.6 kB) - added by michaeltwofish 11 months ago.

Change History

Changed 11 months ago by michaeltwofish

Changed 11 months ago by dmondark

  • component changed from component1 to openid

changed component to the openid plugin

Changed 10 months ago by michaeltwofish

  • status changed from new to closed
  • resolution set to fixed

Fixed in r61.

Add/Change #4 (OpenID login fails when URL is not associated with a user)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.