Changeset 2443

Timestamp:

09/04/08 23:40:29 (3 months ago)

Author:

dmondark

Message:

Do not display errors messages for log entries just because their level is >= warning. Also display minimum information on login failures. Fixes #558 (see ticket for details) and #559.

Location:

trunk/htdocs/system/classes

Files:

• eventlog.php (modified) (1 diff)
• user.php (modified) (3 diffs)
• userthemehandler.php (modified) (1 diff)

trunk/htdocs/system/classes/eventlog.php

@@ -90 +90 @@
         }
         $log->insert();
-        if ( LogEntry::severity( $severity ) >= LogEntry::severity( 'warning' ) ) {
-            Session::error( $message, $module );
-        }
         return $log;
     }

trunk/htdocs/system/classes/user.php

@@ -220 +220 @@
         elseif(!is_object($user)) {
             EventLog::log( sprintf(_t('Login attempt (via authentication plugin) for non-existent user %s'), $who), 'warning', 'authentication', 'habari' );
+            Session::error('Invalid username/password');
             self::$identity = null;
             return false;
@@ -235 +236 @@
             // No such user.
             EventLog::log( sprintf(_t('Login attempt for non-existent user %s'), $who), 'warning', 'authentication', 'habari' );
+            Session::error('Invalid username/password');
             self::$identity = null;
             return false;
@@ -251 +253 @@
             // Wrong password.
             EventLog::log( sprintf(_t('Wrong password for user %s'), $user->username), 'warning', 'authentication', 'habari' );
+            Session::error('Invalid username/password');
             self::$identity = null;
             return false;

trunk/htdocs/system/classes/userthemehandler.php

@@ -53 +53 @@
         catch(Error $e) {
             EventLog::log($e->humane_error(), 'error', 'theme', 'habari', print_r($e, 1) );
+            Session::error($e->humane_error()); //Should we display any error here?
             if(DEBUG) {
                 Utils::debug($e);