Comments link not displayed

[Massimiliano]

What you were attempting to do: viewing the homepage of my blog, default K2 set as theme.

What you expected to happen: to see "% comments" right of the balloon icon.

What did happen: nothing is displayed, page source reads "<span class="commentslink"></span>".

Any other information: running r1305; ThemeHelper plugin installed, both activated and not.

[tinyau]

$theme->fn(), using filter_theme_call_*() hook, is broken after r1303. Besides comment link, atom feed link, jquery link is not shown as well in default K2 theme with themehelper plugin enabled.

[cid]

Hi, I replaced

<span class="commentslink"><?php echo $theme->comments_link( $post, 'No Comments', '%s Comment', '%s Comments' ); ?></span>

with this (old) one:

<span class="commentslink"><a href="<?php echo $post->permalink; ?>#comments" title="Comments to this post"><?php echo $post->comments->approved->count; ?>
<?php echo _n( 'Comment', 'Comments', $post->comments->approved->count ); ?></a></span>

Seems to workaround this problem. It is just the line from 0.3.3 release.

PS: I'm sorry for not knowing this trac software, but I just wanted to tell you how I fixed this temporarily :)

[Massimiliano]

cid's patch works (thanks!). It affects entry.multiple.php, entry.single.php, home.php, page.single.php, search.php, tag.php in the k2 folder.

It should be reverted when $theme->fn() is fixed.

[miklb]

was this not addressed in r1348

[miklb]

comments links changed in r1355. Are the other issues resolved, can this be closed as fixed?

Themehelper function should be new issue.

[ringmaster]

This should go back to the way it was with the theme functions working properly.

[michaeltwofish]

comments_link is currently in the ThemeHelper plugin, so with the plugin activated and the comments code reverted to call $theme->comments_link, this should work. However, we do not currently have a mechanism for describing dependencies, so K2 shouldn't rely on it.

[freakerz]

So should we have ThemeHelper active by default, add that function to core Theme:: or simply leave it as-is?

[freakerz]

This has been fixed for a while, therefore closing.

Thanks to all!