Ticket #1242 (new defect)

Opened 20 months ago

Last modified 16 months ago

AdminHandler::form_user_success should call $form->save()

Reported by: drzax Owned by:
Priority: minor Milestone: 0.9
Component: Habari Core Software Version: SVN
Keywords: user admin handler plugins Cc:

Description

Even though all the default form fields are handled by the AdminHandler::form_user_success function I think it should still call $form->save() somewhere.

By not calling $form->save() it forces plugin authors who add fields to the form to manually save them even if a storage mechanism (such as "user:myplugin") has been specified in the control.

The only downside I see to simply adding a call to $form->save() is that it won't generate a notice - so a little more work is required.

Change History

comment:1 Changed 16 months ago by anon

  • Keywords handler added
  • Milestone changed from Undetermined to 0.9
Note: See TracTickets for help on using tickets.