Ticket #139 (closed defect: fixed)

Opened 10 months ago

Last modified 9 months ago

Nested lists break validation

Reported by: Massimiliano Owned by:
Priority: critical Milestone: 0.4.1
Component: Habari Core Software Version: SVN
Keywords: validation, has_patch Cc:

Description

Habari creates a new paragraph in the line after every </ol> and </ul>. Writing nested lists, it breaks validation.

Input:

<ul>

<li>Item 1

<ul>

<li>A

<li>B

</ul>

<li>Item 2

<ul>

<li>C

<li>D

</ul>

</ul>

Output:

<ul>

<li>Item 1

<ul>

<li>A

<li>B

</ul>

<p><li>Item 2</p> <---

<ul>

<li>C

<li>D

</ul>

<p></ul></p> <---

Attachments

format.dff (2.4 kB) - added by rickc 10 months ago.
Fixes for Format::autop() to give consisten treatment to br tags and stop p tags being put in list.
format.diff (2.3 kB) - added by rickc 10 months ago.
Updated replacement for Format::autop() to keep p tags out of nested lists and treat br tags inside and outside block elements the same.

Change History

Changed 10 months ago by miklb

confirmed as a bug in r1325

Changed 10 months ago by miklb

  • priority changed from minor to critical

Changed 10 months ago by rickc

Fixes for Format::autop() to give consisten treatment to br tags and stop p tags being put in list.

Changed 10 months ago by rickc

This, along with tickets #55 and #56, are problems with Format::autop(). The attached patch seems to work to fix all three problems It seems a messy way to do it, though.

Changed 10 months ago by rickc

  • keywords validation, has_patch added; validation removed

Changed 10 months ago by dmondark

  • milestone changed from 0.4 to Undetermined

Moving to a later milestone

Changed 10 months ago by rickc

Updated replacement for Format::autop() to keep p tags out of nested lists and treat br tags inside and outside block elements the same.

Changed 9 months ago by ringmaster

  • status changed from new to closed
  • resolution set to fixed

In r1397.

Changed 9 months ago by freakerz

  • milestone changed from Undetermined to 0.4.1
Note: See TracTickets for help on using tickets.