Ticket #150 (closed defect: fixed)

Opened 10 months ago

Last modified 9 months ago

Flickr plugin adds JavaScript to every admin page

Reported by: michaeltwofish Owned by:
Priority: minor Milestone: 0.4
Component: Plugins Version: SVN
Keywords: has_patch, flickr_silo Cc:

Description

After [1322] the Flickr media silo adds the 'flickr' media type to the habari JavaScript object on every page in admin. The attached patch adds selectively only to the publish page.

Note, if the rumoured Controller::get_handler()->admin_page property has been included in adminhandler, that should be used instead.

Attachments

flickrsilo_only_publish.patch (1.5 kB) - added by michaeltwofish 10 months ago.
flickrsilo_only_publish.2.patch (1.8 kB) - added by michaeltwofish 10 months ago.
flickrsilo_only_publish.3.patch (1.4 kB) - added by michaeltwofish 9 months ago.

Change History

Changed 10 months ago by michaeltwofish

Changed 10 months ago by michaeltwofish

The patch caused an error on the admin dashboard (because it checked against Controller::get_handler->handler_varspage?, which doesn't exist on the dashboard). The patch has now been corrected.

Changed 10 months ago by michaeltwofish

Changed 10 months ago by michaeltwofish

The second patch uses the new action_admin_{method}_{page} hooks introduced in r1336 to determine whether to add the media type, and is therefore much more readable.

Changed 9 months ago by miklb

  • keywords has_patch added

Changed 9 months ago by dmondark

  • keywords has_patch, flickr_silo added; has_patch removed
  • component changed from Habari Core Software to Plugins

The right component of this ticket is Plugins since its related to Flickr Silo core plugin.

Changed 9 months ago by dmondark

Tested flickrsilo_only_publish.2.patch and it works fine. The 'flickr' media type only exists in the publish pages.

Changed 9 months ago by michaeltwofish

Changed 9 months ago by ringmaster

  • status changed from new to closed
  • resolution set to fixed

In r1365.

Note: See TracTickets for help on using tickets.