Ticket #533 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

users: nothing for no posts

Reported by: mikelietz Owned by: arthus
Priority: trivial Milestone: 0.6
Component: Habari Core Software Version: SVN
Keywords: user, has_patch Cc:

Description

I just created a new user, and upon my return to the users page I see that admin "currently has 1 published post", but my new user "currently has"... and that's it. Shouldn't it say "no published posts" or something similar?

Attachments

users_items.patch (0.8 kB) - added by arthus 4 months ago.
users_items.v2.patch (0.8 kB) - added by msi 4 months ago.

Change History

Changed 4 months ago by arthus

Changed 4 months ago by arthus

  • owner set to arthus
  • status changed from new to assigned

Changed 4 months ago by arthus

  • keywords user, has_patch added; user removed
  • milestone changed from 0.5 to 0.6

Changed 4 months ago by dmondark

  • status changed from assigned to closed
  • resolution set to fixed

in r2248.

Changed 4 months ago by msi

Guys, I have to reopen the ticket. Sorry. But that fix is not translatable. It does not help using

printf( _t( $string )

because poEdit (and other tools) will not detect the string before. This would be better

if ( Posts::count_by_author( $user->id, Post::status('any') ) != 0 ) {
	$string = _t('was last seen %1$s at %2$s and currently has %3$s');
}
else {
	$string = _t('was last seen %1$s at %2$s');
}

Changed 4 months ago by msi

Changed 4 months ago by msi

  • status changed from closed to reopened
  • resolution fixed deleted

Changed 4 months ago by tinyau

  • status changed from reopened to closed
  • resolution set to fixed

In #2268. Thanks msi for the patch.

Note: See TracTickets for help on using tickets.