Ticket #558 (closed defect: fixed)

Opened 4 months ago

Last modified 3 months ago

Not all log entries should become session messages

Reported by: ringmaster Owned by: dmondark
Priority: major Milestone: Undetermined
Component: Habari Core Software Version: SVN
Keywords: Cc:

Description

There are a few places in the code that rely on the event log to create session messages to display those events to the user. They should not do this.

The reasoning is that there are events that should only be displayed to logged-in or admin users.

The event log should not display session messages, and places that rely on session messages being generated from new events should be modified so that they display their messages as appropriate.

Change History

Changed 3 months ago by dmondark

  • owner set to dmondark

Changed 3 months ago by dmondark

  • status changed from new to closed
  • resolution set to fixed

EventLog::log() was displaying error messages whenever the level >= 'warning'. This has been removed and Session:error was added wherever that was used. Fixed in r2443.

Note: See TracTickets for help on using tickets.