K2 <current_page_item> tab disappear

[Starjive]

Say you click in a post or going to another /page/3 the tab is gone :(.

[dmondark]

Personally I can't see that this is a problem. If you consider that "tab" is the home tab, then it would not make sense to keep it "active" when you are in a post or another page (ie. not home). In any case the priority of this should be trivial.

[msi]

Starjive describes the K2/WordPress behaviour. It does not matter to dive into the archive or to display the home page or to display author related entries, etc. The "Home" tab is always enabled. I personally do not have a problem not to have this behaviour in K2/Habari. ;-)

Anyway, we could add the additional requests to "header.php" to fix this; for example:

if( $request->display_home or $request->display_entries_by_tag or ... )

etc.

[dmondark]

Either way is fine by me. All in all this more of an enhancement than a defect.

[miklb]

I personally don't think this should be added to the habari-k2 theme, rather, if someone wants to add a wiki page outlining how this is done, and how to modify the conditional to have the primary tab active on more than the home page, great.

Not everyone will have "Blog" as the tab. Some may want "Home" as the tab, then this active tab on entry.mulitple.php would wind up getting a ticket saying their home link is active on pages other than "home".

The only reason I actually added this to k2 in the first place was that their was existing CSS markup for the class, as well as an example of how to add your own class (which I prefer, vs having a hard-coded class). Thus marking wontfix.